Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPublishedContent Linq & HasCulture #3305

Closed
zpqrtbnk opened this issue Oct 16, 2018 · 2 comments
Closed

IPublishedContent Linq & HasCulture #3305

zpqrtbnk opened this issue Oct 16, 2018 · 2 comments

Comments

@zpqrtbnk
Copy link
Contributor

zpqrtbnk commented Oct 16, 2018

child of #3661

When getting a document from the content cache with eg cache.GetById(1234), we get the document "for all cultures" but that document may actually not be available for the current culture.
We have an HasCulture method for this, which checks whether the content is avail for the current (or explicitely specified) culture.
That method should probably be used in many places in our Linq navigation, such as Children() or Descendant(), so that we do not return non-available documents.
Or, maybe we want to but then, we have to document that ppl need to filter? And maybe create an extension method filter .WhereHasCulture()?

@bergmania
Copy link
Member

bergmania commented Jan 16, 2019

PR: #4096

@bergmania bergmania removed their assignment Jan 16, 2019
@zpqrtbnk zpqrtbnk self-assigned this Jan 17, 2019
@zpqrtbnk
Copy link
Contributor Author

tests green, looks good - have fixed/changed a few things and un-commented tons of tests that had been commented - still all green - liking it - merged

@zpqrtbnk zpqrtbnk removed their assignment Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants