Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a health check for umbraco application url #11776

Merged
merged 3 commits into from
Dec 21, 2021

Conversation

elit0451
Copy link
Member

@elit0451 elit0451 commented Dec 20, 2021

Details

  • Adding a new health check which checks if the value of umbracoApplicationUrl is set in the umbracoSettings.config file;
  • There is also the option to set it according to the site URL that you are currently using.

Test

  • Navigate to the Settings section > Health Check > Security
  • Use the Check group button
  • Verify that the information displayed in Application URL Configuration part is correct
    • Ex: If umbracoApplicationUrl="" in your umbracoSettings.config file, you will see a warning (⚠️) and you will be able to set its value through the newly added button (Set Umbraco application URL in Config)
  • After clicking the button it should result in success (✔️) and the value in the config should be updated with the application's URL

elit0451 added a commit that referenced this pull request Dec 21, 2021
@Zeegaan Zeegaan merged commit bd1c392 into v8/dev Dec 21, 2021
@Zeegaan Zeegaan deleted the v8/bugfix/AB15639-umbracoApplicationUrl-healthcheck branch December 21, 2021 10:35
@Zeegaan
Copy link
Member

Zeegaan commented Dec 21, 2021

Tested this and it works great 👍

Code LGTM! 👓

bergmania pushed a commit that referenced this pull request Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants