Add a basic oEmbedProvider for LottieFiles animations #12151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes
Description
LottieFiles (https://lottiefiles.com/) - The popular opensource JSON-based animation file format that enables designers to ship animations on any platform, has just started supporting OEmbed, from their gallery of community animations, which makes it a lovely candidate for adding an OEmbedProvider to Umbraco's Embed functionality for LottieFiles.
I was going to create a package for this but then it would be called Our.Umbraco.Lottie and I think that would be confusing for people, as they consider Our Umbraco Lottie to be @LottePitcher ... so I think therefore it MUST go in the core.
How to test?
Visit the LottieFiles gallery of 'free animations'
https://lottiefiles.com/featured
search and find the animation you want to embed, on the right hand side there is a panel of information about the animation, and one of the options is to copy the oEmbedUrl
grab that
Go back into Umbraco, and then inside a grid cell or Rich Text Area, click on the Embed option.
paste in the Oembed Url
Delight at seeing an animation in the embed panel
update your width and height as needs be...
Select and publish your page - your animation will appear!
There is really lots more you can do with LottieFiles, and I'm sure someone will build a package to take advantage of the options, and allow you to upload the JSON into the media section etc, but for the timebeing, adding the oEmbedProvider might help spread the word about it's existence...
This PR just adds a new LottieFiles OEmbedProvider, and adds it to the stack of providers in the Umbraco Builder.
While these are guidelines and not strict requirements, they really help us evaluate your PR quicker.
Thanks for considering this contributing to Umbraco CMS!