Hotfix: Move allow edit invariant from non default setting to content settings #12960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👁️ 👃 👁️ |
Zeegaan
deleted the
v10/hotfix/move_allow_edit_invariant_to_content_settings
branch
nikolajlauridsen
added a commit
that referenced
this pull request
Sep 7, 2022
… settings (#12960) * Use ContentSettings instead of SecuritySettings for AllowEditInvariantFromNonDefault * Make it backwards compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
AllowEditInvariantFromNonDefaultsetting fromSecuritySettingstoContentSettingsbased on user feedback.This move is done while remaining backwards compatible, meaning that you can use either setting, but
ContentSettingswill always take priority.