Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Smidge up to v4.1.1 #13071

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Conversation

Jeavon
Copy link
Contributor

@Jeavon Jeavon commented Sep 28, 2022

Smidge v4.1.1 updates Nuglify from v1.13.12 to v1.20.2 with tons of bug fixes for many issues some are detailed in this forum thread https://our.umbraco.com/forum/using-umbraco-and-getting-started/108469-backofficeadmin-css-smidgenuglify-error-breaking-package-styling

@github-actions
Copy link

github-actions bot commented Sep 28, 2022

Hi there @Jeavon, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@mikecp
Copy link
Contributor

mikecp commented Sep 28, 2022

Thanks Jeavon for this update 👍
I just tested and all seem to still run normally, so let's merge 😁
Cheers!

@mikecp mikecp merged commit 17101da into umbraco:v10/contrib Sep 28, 2022
@hemraker hemraker added dependencies Pull requests that update a dependency file and removed type/feature labels Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community/pr dependencies Pull requests that update a dependency file release/10.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants