Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added various Block Grid translations (EN & NL) #13488

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Added various Block Grid translations (EN & NL) #13488

merged 3 commits into from
Nov 28, 2022

Conversation

cornehoskam
Copy link
Contributor

@cornehoskam cornehoskam commented Nov 28, 2022

As per #13480, changed the allowBlockInAreasHelp translation text in English, and added various Dutch translations having to do with the Block Grid Editor while I was at it! (Not all of them yet, at this point in time!) 🙂

@cornehoskam cornehoskam changed the title Added various translations Added various Block Grid translations (EN & NL) Nov 28, 2022
Copy link
Member

@elit0451 elit0451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! (Can't guarantee the Dutch translations but I trust you 😅 )

Could I ask you to make the change in the en_us.xml file as well?

@cornehoskam
Copy link
Contributor Author

There you go @elit0451 🙂

@elit0451
Copy link
Member

Thanks for the help @cornehoskam 🙌
I will close the issue you mentioned and merge this PR shortly 😊

@elit0451 elit0451 merged commit a4e67bf into umbraco:v11/contrib Nov 28, 2022
nikolajlauridsen pushed a commit that referenced this pull request Nov 28, 2022
* Added various translations

* Added another translation

* Change request
nikolajlauridsen added a commit that referenced this pull request Dec 1, 2022
* update marketplace url to its final, live url

* Added various Block Grid translations (EN & NL) (#13488)

* Added various translations

* Added another translation

* Change request

* Revert breaking changes adding IContextCache to deploy connectors (#13489)

* Remove breaking changes in Deploy connector interfaces

* Add extension methods for calling the new interface methods in a backwards-compatible way

* Create and pack empty file to add TFM dependency (#13475)

* Change login image to new SVG. (#13493)

* Only add global usings when ImplicitUsings is enabled (#13491)

* bump to rc6

* V11: Allow changing logging directory from configuration (#13485)

* Allow changing logging directory from configuration

* Clean up

* Missing return statement

* Apply suggestions from code review

Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com>

* Update src/Umbraco.Core/Constants-SystemDirectories.cs

Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com>

Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com>

* Move login.svg file

* Make sure contexbar fits within the available space (#13467)

* Make sure contexbar fits within the available space

* Ensuring context bar moves above, no matter size of it.

* Fixing apperance of connection-fixers

* Info panes not loading prerequisites (#13486)

* load relations immediately on init and remove call to non-existing function `appTabChange` on destroy

* load relations immediately on init and remove now not-used eventsService

* do not set layout gaps (#13496)

* Nuget updates (#13478)

* Updated nuget packages

* Remove npoco update

Co-authored-by: nikolajlauridsen <nikolajlauridsen@protonmail.ch>

* Nuget updates (#13478)

* Updated nuget packages

* Remove npoco update

Co-authored-by: nikolajlauridsen <nikolajlauridsen@protonmail.ch>

* Bump version to final

* V11/cherry pick flaky test (#13506)

* V10/feature/fixing flaky acceptance test (#13473)

* Bumped version

* Handle external authentication providers (#13487)

Co-authored-by: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com>
Co-authored-by: Corné Hoskam <choskam@hotmail.com>
Co-authored-by: Ronald Barendse <ronald@barend.se>
Co-authored-by: Niels Lyngsø <nsl@umbraco.dk>
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com>
Co-authored-by: nikolajlauridsen <nikolajlauridsen@protonmail.ch>
Co-authored-by: Andreas Zerbst <73799582+andr317c@users.noreply.github.com>
nul800sebastiaan pushed a commit that referenced this pull request Dec 14, 2022
* Added various translations

* Added another translation

* Change request

(cherry picked from commit a4e67bf)

# Conflicts:
#	src/Umbraco.Core/EmbeddedResources/Lang/en.xml
#	src/Umbraco.Core/EmbeddedResources/Lang/en_us.xml
@nul800sebastiaan
Copy link
Member

Cherry picked for 10.4.0 93c0a4e

a-t-k pushed a commit to a-t-k/Umbraco-CMS that referenced this pull request Jan 6, 2023
* Added various translations

* Added another translation

* Change request

(cherry picked from commit a4e67bf)

# Conflicts:
#	src/Umbraco.Core/EmbeddedResources/Lang/en.xml
#	src/Umbraco.Core/EmbeddedResources/Lang/en_us.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants