Prevent false redirect to "Page Not Found" from UmbracoMemberAuthorize attribute handling #14036
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13946
Details
[UmbracoMemberAuthorize]
attribute checks if the current member is authorized for a given request. When the member wasn't authorized we set the result to Forbidden and then we were redirected to a 404 page which wasn't the intention. This PR fixes the behaviour to return 401 Unauthorized when the member is not logged in and 403 Forbidden when the member is not of a permitted type or group.Test
@Model.Value("RTEaliasHERE")
;[UmbracoMemberAuthorize("", "", "")]
attribute and verify that the said behaviour is still correct - there are some examples in https://docs.umbraco.com/umbraco-cms/v/10.latest-lts/reference/routing/umbraco-api-controllers/authorization#using-memberauthorizeattribute