Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V14: Remove member list view #15979

Merged
merged 4 commits into from Apr 12, 2024
Merged

V14: Remove member list view #15979

merged 4 commits into from Apr 12, 2024

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Apr 3, 2024

Notes

  • Remove default member list view data-type from installation
  • Makes the member - list view deletable
  • Removes the Member list view key constant

How to test

  • start from v14/dev branch

  • Install the solution

  • Swap to this branch

  • Ensure that you can delete the member list view.

  • Start from this branch

  • Install the solution

  • Assert that the member list view no longer gets created upon install

nikolajlauridsen
nikolajlauridsen approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests good 👍

@nikolajlauridsen nikolajlauridsen merged commit 89de08a into v14/dev Apr 12, 2024
16 checks passed
@nikolajlauridsen nikolajlauridsen deleted the v14/chore/remove-member-list-view branch April 12, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolajlauridsen nikolajlauridsen nikolajlauridsen approved these changes

Assignees
No one assigned
Labels
category/breaking release/14.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zeegaan @nikolajlauridsen @bergmania