V14: Remove member list view

src/Umbraco.Cms.Api.Management/Controllers/DataType/ConfigurationDataTypeController.cs

@@ -25,7 +25,6 @@ public Task<IActionResult> Configuration(CancellationToken cancellationToken)
             CanBeChanged = _dataTypesSettings.CanBeChanged,
             DocumentListViewId = Constants.DataTypes.Guids.ListViewContentGuid,
             MediaListViewId = Constants.DataTypes.Guids.ListViewMediaGuid,
-            MemberListViewId = Constants.DataTypes.Guids.ListViewMembersGuid,
         };
         return Task.FromResult<IActionResult>(Ok(responseModel));
     }

src/Umbraco.Cms.Api.Management/ViewModels/DataType/DatatypeConfigurationResponseModel.cs

@@ -9,6 +9,4 @@ public class DatatypeConfigurationResponseModel
     public required Guid DocumentListViewId { get; init; }
 
     public required Guid MediaListViewId { get; init; }
-
-    public required Guid MemberListViewId { get; init; }
 }

src/Umbraco.Core/Constants-DataTypes.cs

@@ -284,11 +284,6 @@ public static class Guids
             /// </summary>
             public static readonly Guid ListViewMediaGuid = new(ListViewMedia);
 
-            /// <summary>
-            ///     Guid for List View - Members
-            /// </summary>
-            public static readonly Guid ListViewMembersGuid = new(ListViewMembers);
-
             /// <summary>
             ///     Guid for Date Picker with time
             /// </summary>

src/Umbraco.Core/Models/DataTypeExtensions.cs

@@ -18,7 +18,6 @@ public static class DataTypeExtensions
         Constants.DataTypes.Guids.TagsGuid,
         Constants.DataTypes.Guids.ListViewContentGuid,
         Constants.DataTypes.Guids.ListViewMediaGuid,
-        Constants.DataTypes.Guids.ListViewMembersGuid,
         Constants.DataTypes.Guids.DatePickerWithTimeGuid,
         Constants.DataTypes.Guids.ApprovedColorGuid,
         Constants.DataTypes.Guids.DropdownMultipleGuid,
@@ -56,7 +55,6 @@ public static class DataTypeExtensions
         // these data types are required for default list view handling
         Constants.DataTypes.Guids.ListViewContentGuid,
         Constants.DataTypes.Guids.ListViewMediaGuid,
-        Constants.DataTypes.Guids.ListViewMembersGuid,
     };
 
     /// <summary>

src/Umbraco.Infrastructure/Migrations/Install/DatabaseDataCreator.cs

@@ -1,4 +1,4 @@
 using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
@@ -673,26 +673,7 @@
                 CreateDate = DateTime.Now,
             },
             Constants.DatabaseSchema.Tables.Node,
             "id");
-        ConditionalInsert(
-            Constants.Configuration.NamedOptions.InstallDefaultData.DataTypes,
-            Constants.DataTypes.Guids.ListViewMembers,
-            new NodeDto
-            {
-                NodeId = Constants.DataTypes.DefaultMembersListView,
-                Trashed = false,
-                ParentId = -1,
-                UserId = -1,
-                Level = 1,
-                Path = $"-1,{Constants.DataTypes.DefaultMembersListView}",
-                SortOrder = 2,
-                UniqueId = Constants.DataTypes.Guids.ListViewMembersGuid,
-                Text = Constants.Conventions.DataTypes.ListViewPrefix + "Members",
-                NodeObjectType = Constants.ObjectTypes.DataType,
-                CreateDate = DateTime.Now,
-            },
-            Constants.DatabaseSchema.Tables.Node,
-            "id");
         ConditionalInsert(
             Constants.Configuration.NamedOptions.InstallDefaultData.DataTypes,
             Constants.DataTypes.Guids.Tags,

src/Umbraco.Infrastructure/Migrations/Upgrade/V_14_0_0/AddListViewKeysToDocumentTypes.cs

@@ -115,11 +115,6 @@ private void MigrateSqlite()
             return Constants.DataTypes.Guids.ListViewMediaGuid;
         }
 
-        if (dto.NodeDto.NodeObjectType == Constants.ObjectTypes.MemberType)
-        {
-            return Constants.DataTypes.Guids.ListViewMembersGuid;
-        }
-
         // No custom list view was found, and not one of the default types either. Therefore we cannot find it.
         return null;
     }

src/Umbraco.Infrastructure/Migrations/Upgrade/V_14_0_0/MigrateDataTypeConfigurations.cs

@@ -1,4 +1,4 @@
 using System.Text.Json.Nodes;
 using Microsoft.Extensions.Logging;
 using NPoco;
 using Umbraco.Cms.Core;
@@ -93,7 +93,7 @@
                     PropertyEditorAliases.DropDownListFlexible => HandleDropDown(ref configurationData),
                     PropertyEditorAliases.EmailAddress => HandleEmailAddress(ref configurationData),
                     PropertyEditorAliases.Label => HandleLabel(ref configurationData),
-                    PropertyEditorAliases.ListView => HandleListView(ref configurationData, dataTypeDto.NodeDto?.UniqueId, allMediaTypes, allMemberTypes),
+                    PropertyEditorAliases.ListView => HandleListView(ref configurationData, dataTypeDto.NodeDto?.UniqueId, allMediaTypes),
                     PropertyEditorAliases.MediaPicker3 => HandleMediaPicker(ref configurationData, allMediaTypes),
                     PropertyEditorAliases.MultiNodeTreePicker => HandleMultiNodeTreePicker(ref configurationData, allContentTypes, allMediaTypes, allMemberTypes),
                     PropertyEditorAliases.MultiUrlPicker => HandleMultiUrlPicker(ref configurationData),
@@ -308,13 +308,11 @@
 
     // ensure that list view configs have all configurations, as some have never been added by means of migration.
     // also performs a re-formatting of "layouts" and "includeProperties" to a V14 format
-    private bool HandleListView(ref Dictionary<string, object> configurationData, Guid? dataTypeKey, IMediaType[] allMediaTypes, IMemberType[] allMemberTypes)
+    private bool HandleListView(ref Dictionary<string, object> configurationData, Guid? dataTypeKey, IMediaType[] allMediaTypes)
     {
         var collectionViewType = dataTypeKey == Constants.DataTypes.Guids.ListViewMediaGuid || allMediaTypes.Any(mt => mt.ListView == dataTypeKey)
             ? "Media"
-            : dataTypeKey == Constants.DataTypes.Guids.ListViewMembersGuid || allMemberTypes.Any(mt => mt.ListView == dataTypeKey)
-                ? "Member"
-                : "Document";
+            : "Document";
 
         string? LayoutPathToCollectionView(string? path)
             => "views/propertyeditors/listview/layouts/list/list.html".InvariantEquals(path)

tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/Repositories/DataTypeDefinitionRepositoryTest.cs

@@ -250,7 +250,7 @@ public void Can_Perform_GetAll_On_DataTypeDefinitionRepository()
             Assert.That(dataTypeDefinitions, Is.Not.Null);
             Assert.That(dataTypeDefinitions.Any(), Is.True);
             Assert.That(dataTypeDefinitions.Any(x => x == null), Is.False);
-            Assert.That(dataTypeDefinitions.Length, Is.EqualTo(35));
+            Assert.That(dataTypeDefinitions.Length, Is.EqualTo(34));
         }
     }
 

tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/DataTypeServiceTests.cs

@@ -437,7 +437,6 @@ public async Task Cannot_Move_DataType_To_Non_Existing_Container()
     [TestCase(Constants.DataTypes.Guids.Checkbox)]
     [TestCase(Constants.DataTypes.Guids.ListViewContent)]
     [TestCase(Constants.DataTypes.Guids.ListViewMedia)]
-    [TestCase(Constants.DataTypes.Guids.ListViewMembers)]
     public async Task Cannot_Delete_NonDeletable_DataType(string dataTypeKey)
     {
         var dataType = await DataTypeService.GetAsync(Guid.Parse(dataTypeKey));