Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor settings arrays to ISet<T> (to ensure unique values and make them easily mutable) #16058

Open
wants to merge 2 commits into
base: v15/dev
Choose a base branch
from
+110 −97

Refactor setting arrays to sets

e18c6c8
Select commit
Loading
Failed to load commit list.
Open

Refactor settings arrays to ISet<T> (to ensure unique values and make them easily mutable) #16058

Refactor setting arrays to sets
e18c6c8
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v14/dev) succeeded Apr 15, 2024 in 31s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method RichTextEditorSettings.cs: HashSet

Annotations

Check warning on line 20 in src/Umbraco.Core/Configuration/Models/RichTextEditorSettings.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)

❌ New issue: Large Method 

HashSet has 96 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis