U4-9095 First take localized text into account before the title property when… #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… working with tree headers
TimGeyssens
changed the title
|
Hi @TimGeyssens !! I bet you completely forgot about this one? 🤔 Very sorry for the long delay. This change is great! The code had moved around a little bit so I fixed up the merge conflict, but this is now working.. finally! Thanks for the help and wow.. your first PR merged, you've finally earned that much coveted Contrib badge! 🙌 https://our.umbraco.com/member/1171 I think I've seen your name in the repo before though, so you should have had it for a long time! 😉 Thanks again Tim! |
|
Sweet, thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… working with tree headers
Since it doesn't seem possible to localize these currently...
Related to issue http://issues.umbraco.org/issue/U4-9095#