Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14] Fix multiple upgrader issues #16339

Merged
merged 9 commits into from
May 27, 2024
Merged

[v14] Fix multiple upgrader issues #16339

merged 9 commits into from
May 27, 2024

Conversation

Migaroez
Copy link
Contributor

@Migaroez Migaroez commented May 22, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

Fixed issues

  • An error is thrown during unattended upgrade because of changes to the preview hub that could no longer deal with full cache refreshes (no key is present)
  • When the migrations changes the user in such a way that the link between the already issued tokens and the user store object is broken, authorization will throw server errors => a revoke token mechanism is introduced that can be called by the upgrader when a migration deems it necessary.

Open related issues

  • After login to authorize the upgrade, the user is redirected to the back office instead of the upgrade screen. This results in the back office being in a bad state due to migrations not having ran yet. This can be circumvented by refreshing the page.

Testing

  • create a new v13 latest database with 1 custom datatype/contenttype/document
  • use this database to run the upgrader both unattended and attended. The only issue that should remain is having to refresh the page after login as described above.

@Migaroez Migaroez changed the base branch from contrib to v14/dev May 22, 2024 07:53
@Migaroez Migaroez requested review from bergmania and kjac May 22, 2024 08:18
Clarified with a comment
# Conflicts:
#	src/Umbraco.Cms.Api.Management/Preview/PreviewHubUpdater.cs
@Migaroez
Copy link
Contributor Author

Dev merge issues and broken test fixes are incoming

@kjac
Copy link
Contributor

kjac commented May 23, 2024

Uh. I think we may have been fixing the same issue with the preview hub 🤦 #16338 has been merged in and solves the same issue.

@Migaroez
Copy link
Contributor Author

Uh. I think we may have been fixing the same issue with the preview hub 🤦 #16338 has been merged in and solves the same issue.

Yup, merged your correction in on my machine already, will be pushed shortly

@kjac kjac merged commit e5e87c9 into v14/dev May 27, 2024
15 checks passed
@kjac kjac deleted the v14/fix/upgrader-issues branch May 27, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants