UDUF (U4-10975) Failed Logon Attempts resets to 0 after maximum number of attempts #2462
Conversation
Shazwazza
changed the title
|
Hi @iofsauron , Many thanks for the PR. I am going to review this and I shall keep you posted on how things go this end with the testing and reviewing. :-) Regards, |
| @@ -507,15 +507,22 @@ private static string NewSecurityStamp() | |||
|
|
|||
| #endregion | |||
|
|
|||
| public override Task<IdentityResult> SetLockoutEndDateAsync(int userId, DateTimeOffset lockoutEnd) | |||
| public override async Task<IdentityResult> SetLockoutEndDateAsync(int userId, DateTimeOffset lockoutEnd) | |||
There was a problem hiding this comment.
Unfortunately this is a public method in a public class. Changing the method is a breaking changes as it will require everyone using it to have to recompile the code.
So we'll have to keep this one non-async for now!
There was a problem hiding this comment.
We can change to async, this isn't changing the method signature at all. It's already async enabled since its returning a Task. Same as the other method. All the async keyword does is modify the IL used to call the method.
| /// <remarks> | ||
| /// Doesnt set fail attempts back to 0 | ||
| /// </remarks> | ||
| public override async Task<IdentityResult> AccessFailedAsync(int userId) |
There was a problem hiding this comment.
Same for this method, unfortunately we can't just change it to async.
|
Thanks @iofsauron! Sorry for the late reply but we finally got round to trying this out and it works great! 👍 🏅 If you have a profile on Our Umbraco, could you link it here? I'd love to give you a contributor badge! |
Failed Logon Attempts resets to 0 after maximum number of attempts
See this: http://issues.umbraco.org/issue/U4-10975