Use the umb-toggle directive for the "True/False" property editor #2667
Conversation
…ggle based on the umb-toggle directive
|
Hi, Many thanks for the PR. We will review the PR within the next 14 days. Regards, |
|
Hi, I checked out the PR locally but I am unable to see this in action. I am not sure whether I am being silly here but from what I understand the True/False checkbox should be a shiny toggle switch? Poornima |
|
Hi Poornima Could you post a screendump of what you're looking at? I'll have a look when I get home from work and then update this thread with some images so we can wipe out any misunderstandings and confusion :) /Jan |
|
@poornimanayar Did you remember to run the Gulp build? And maybe you need to update the version number in |
|
Good catch @nul800sebastiaan . I ll get the gulp build done. |
|
@nul800sebastiaan That got it up and running. I shall try and get going on this. Poornima |
|
|
|
Cool stuff! Thanks @BatJan ! |
|
YES! Awesome - Thanks folks! That feeling ;-) |
|
😂 😂
|
|
Awesome!
…On 5 June 2018 at 11:52, Sebastiaan Janssen ***@***.***> wrote:
😂 😂
[image: prinception]
<https://user-images.githubusercontent.com/304656/40971827-2779ff5c-68bf-11e8-8e80-6ec61484addf.gif>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2667 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADwleVEWwGeZs5DnNI20GQGzmVLxicWPks5t5mLUgaJpZM4UXQef>
.
--
Regards,
Poornima Nayar
|
|
And this is why I'm so happy to be part of this team! :) |
Prerequisites
Description
Link to issue tracker: http://issues.umbraco.org/issue/U4-11408
I have added the umb-toggle directive in the views of the property editor and the property prevalue editor and I have added a toggle() method in the controllers so update the toggle with true/false values and made sure that the value for the modal i still saved as a string.
I also removed the $watch method from the controller of the property editor saving at little bit of CPU power :-)
Let me know if there are some parts of the code that I should improve. I have tested that the states are svaed correctly both when setting up the datatype and also when using it on a page. The value converters still work too.