Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lecoati CSS reference removed (issue #3147) #3156

Merged
merged 1 commit into from Oct 8, 2018
Merged

Lecoati CSS reference removed (issue #3147) #3156

merged 1 commit into from Oct 8, 2018

Conversation

jannikanker
Copy link
Contributor

ApprovedColorPickerController had a reference for no apparent reason.

Prerequisites

Description

Simple removal of a stylesheet that was loaded for no reason.

To test after removal:

  • Edit "Approved Color" datatype and add some colors.
  • Add an "Approved Color" property to a doctype
  • See that everything looks right and saves correctly.

ApprovedColorPickerController had a reference for no apparent reason.
@nul800sebastiaan nul800sebastiaan merged commit 6b55c11 into umbraco:dev-v7 Oct 8, 2018
@nul800sebastiaan
Copy link
Member

Thanks @jannikanker ! 👍

@nul800sebastiaan
Copy link
Member

Hi there @jannikanker,

First of all: A big #H5YR for contributing to Umbraco during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🙏

If you haven't heard already we have had a record breaking amount of PR's in both the CMS and the Documentation repository. You can read all about the numbers in the Umbraco Hacktoberfest Aftermath blog post.

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!

Receive your swag! 👈 Please follow this link to fill out and submit the form, before November 21st 2018.

Following this date we'll be sending out all the swag, which also means that it might not reach your doorstep before December, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The Umbraco PR Team & The Documentation Curators

@jannikanker jannikanker deleted the patch-1 branch February 7, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants