V8: Ensure consistency in the way panels are spaced #5104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @kjac Yay for consistency! We'll let you know if we need changes and merge if not. Em |
|
Great, thanks! |
|
@kjac super great, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #5094
Description
As described in #5094, the various panel types are vertically spaced differently throughout the UI. This PR makes the spacing consistent (20px).
The following parts are directly affected by this change (read: you can tell there's a difference, because they have multiple panels on the same page):
Examples
Content info app
The most prominent example is probably the content info app, because it's the most visited in the list above. It currently looks like this:
With this PR applied it looks like this:
Edit user
Another example is edit user. It currently looks like this:
With this PR applied, it looks like this:
Log viewer
Final example is the log viewer. It currently looks like this:
With this PR applied, it looks like this: