Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Fix missing image dimensions #5201

Merged

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Apr 8, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

Description

This is the V8 implementation of #5200 - same issue and same fix, but due to code restructuring from V7 to V8 the fix can't be merged ... thus another PR 馃帀

Testing this PR

Same procedure as for #5200:

  1. Upload a few images of different formats to the media library and verify that their dimensions are saved correctly.
  2. Upload this image to the media library and verify that its dimensions are also saved correctly.

@kjac kjac mentioned this pull request Apr 8, 2019
1 task
@emmaburstow
Copy link
Contributor

Hi @kjac

Thanks for this!

Em

@nul800sebastiaan nul800sebastiaan merged commit 655befd into umbraco:v8/dev Apr 22, 2019
@nul800sebastiaan
Copy link
Member

SuperTak!

@kjac kjac deleted the v8-fix-missing-image-dimensions branch April 22, 2019 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants