U4-4507 - Make expand arrow in sections as a toggle #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have made some suggestions, so the right arrow act as a toggle button, so you easily can collapse the extra overflow-sections. Furthermore I have made some changes, so when you click userDialog or helpDialog other open dialogs close and also sections. When you click a section or expand it also close dialogs, so you don't have to close those dialogs first.
| @@ -22,6 +22,9 @@ function sectionsDirective($timeout, $window, navigationService, treeService, se | |||
| if (scope.showTray) { | |||
| return 'slide'; | |||
| } | |||
| else if (scope.showTray === false) { | |||
| return 'slide'; | |||
| } | |||
There was a problem hiding this comment.
This make the ekstra trays slide when they are collapsed.
IE10 displayed a text cursor for tray and help section. Added cursor: pointer; to make sure a pointer cursor is displayed.
Change code for in help.controller.js as it was.
Shazwazza
added a commit
that referenced
this pull request
May 7, 2015
U4-4507 - Make expand arrow in sections as a toggle
|
Great stuff!! tested and works great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made some suggestions, so the right arrow act as a toggle button,
so you easily can collapse the extra overflow-sections. Furthermore I
have made some changes, so when you click userDialog or helpDialog other
open dialogs close and also sections. When you click a section or expand
it also close dialogs, so you don't have to close those dialogs first.
http://issues.umbraco.org/issue/U4-4507
In the top of the sections, just below the avatar, I made sure that the horizontal line follow the line across to the tree area and editing area, and I added some additional borders to seperate the different sections.
I like the effect that the arrow just rotate, but I have added some comments in the code if you rather want to switch to a left arrow icon without the rotate effekt.
On smaller screen resolutions the tree menu is hidden, so when your cursor leave the sections the the tray is closed - can the tray be closed when you click outside the sections e.g. in the tree area or editing area? The user dialog and help dialog are closed when you click these areas.
Finally I also made a change to use small versions of thumbnails in help panel: http://issues.umbraco.org/issue/U4-4028
Instead of displaying large image like this: http://umbraco.tv/media/88895/settings-and-styles.jpg, why not use the _thumb http://umbraco.tv/media/88895/settings-and-styles_thumb.jpg. This thumb has a width of 100px and the thumbnails are anyway scaled to a width of 90px. However it seems that not all these video thumbnails have a _thumb image generated? And if the large images not are used inside Umbraco, it would be better to only request the _thumb image e.g. 100x56px instead of requesting images with a image size of 1280x720px.