Fixed membership provider to correctly log failed attempts. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for looking in to this, i'll wait for Sebastian to review as well. In the mean time if this is related to or fixes any of these issues can you please update them ? http://issues.umbraco.org/issue/U4-2124 |
|
Confirmed this is the fix for U4-2124. U4-1983 is not related. |
|
Thanks, looks good to me too! |
nul800sebastiaan
added a commit
that referenced
this pull request
Aug 19, 2013
Fixed membership provider to correctly log failed attempts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the UmbracoMembershipProvider was not updating the failed login attempts even though I have these two attributes defined on the provider in web.config:
And those two properties exist on my default member type. In looking at the code, I believe it is missing a call to Save() after updating those properties.