Add migrations for various pre-value errors #7957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminc
added a commit
to benjaminc/Umbraco-CMS
that referenced
this pull request
Apr 13, 2020
|
Hiya @benjaminc, Thanks for your work here and for the description. It gives us plenty to work with. Seb has linked it to issue #7939 too. We'll take a look and let you know if we need anything. Emma |
|
Are these migration fixes targeted for 8.7, or were they not going to be included in that release? |
warrenbuckley
pushed a commit
that referenced
this pull request
Jun 30, 2020
* add style to create-option in itempicker + removing overflow hidden * style adjustment * clean up of html * correct sentence to use the number 7 * correct overlays, so they can use size * numberrange prevalue editor * add confirmRemove overlay * correcting primary btn colors * move confirmMessage below content of overlay. * min max validation for numberrange * remove comment * improved actions for block list * use file tree for view picker * style adjustment to border of creator item in item-picker * vertical align * clean up + validation limit range * rename ElementTypes to Blocks * implement block list editor * renaming * use Chrome Headless for unit tests * test for blockEditorService * safer code * block list editor * rename view to overlayView * block editor work * Revert "rename view to overlayView" This reverts commit 5b910c1. * block editor implementation * sync models * block list editor copy paste feature * order var declarations * remove unused paste function * block list editor better naming * simpler label generation * clean up * compile config for test mode * Chrome Debug for VS code * promise test working * space change * another two tests * more tests for block list editor * provide key on blockModel for angularJS performance optimization * syncronization from infinite editing layers * use an isolated scope * more tests * fix C# test * remove unused block watcher component * clean css * only show on hover or focus for block-actions * clean up and prepare for implementing settings * remove console * Add ability to render block list editor using Grid style rendering extension * Enable Block List Editor settings editing * Add Stacked Content to Block List migration * Block Editor: Clean-up, refactoring, one step closer being ready for Content-Apps * changes naming to Submit, to avoid misunderstanding. * use a common variable on the block model for isOpen, to be able to make Actions show when open. * NotSupported property editor, to be used when an editor is not supported in the given context. * remove unused controller * Hide group header if only one group is presented * rename notsupport property editor css class * smaller header for property group * hide description if no description is presented * css adjustments * Inline create button styling: Better spacing, darker blue color for Focus Outline, moving the plus icon to mouse position for better visual appearance. * css correction * Add references for picked items * Revert commit 45e892f - Changes api to GetData * Use the .Data propertry as opposed to GetData in this PartialView * Fix block list test failures * Just parsing layout as model for partial views. * minor adjustments * Remove DB migrations so that they can be reviewed as a block * Add migrations for new block editor * Update default rendering partial view * Add error handling to default template * Handle color picker data in stacked content * BlockList PreValue Editor opens configurations as overlay * translation for prevalue editor property group headlines * blockcard corrections * block list prevalue corrections * revert agressive clean up * Block Picker * MaxPropertyWidth PreValue + Implementation * Incorporate latest block list editor changes, update migration for changed configuration * Change declared converter type * Handle invalid data type references * Remove code duplicated from PR #7957 * use ElementModel for the ContentModel of an ElementType. So we can use ElementTypeModel for the ModelDefinition aka. the Type. * do still show itempicker for BlockConfiguration even though there is no ElementTypes to pick. This enables the option to create a new ElementType to be used. * use the right wrapper, for correct spacing * parse item * correct fallback for label * removed unused callback * paste feature for block-picker * localize block-picker tabs * Slightly change for shadow on block-picker item hover * Localization of BlockEditor Settings Tab * localizationService * only filter when more than 8 items available * Add multiple blocks if hold down CTRL or SuperKey * adds notes * ability to add a scoped stylesheet for block view * make scoped block draggable + style adjustments * provide index for custom view * rename contentModel to data + rename layoutModel to layout * clean up * more localization * openSettings option for block editor * minor changes for a better developer experience * paste mistake corrected * only manipulate content-content-app if its present * make small overlays slightly bigger * moved block list entry editor into block list editor folder * limit labelinterpretator to only runs ones pr. edit. and lets make sure to have a label thought we dont have any properties. * fixed inline views gulp watcher * changed vm to a better controller instance name * make watch for views work again. * able to re run watch * make js up to date * fix white background of image-picker * media-picker container class * loading indication * adjust unit tests to latest interface * getting started on JS Docs * converting code to use contentTypeKey instead of contentTypeAlias, still missing a few TODOs. * revert change * add todo * use Guid for Key * use key * Updates the caching layer to handle GUID keys for content types while preserving backwards compat, fixes unit tests, removes the strongly typed lists for the block editor value since it's unecessary * Reverts the nested content changes, fixes up the GetEmptyByKey * Returns ContentTypeKey from the server, updates js to use this everywhere and fix all js tests. * Allows key in SimpleContentType * correct for the new spelling * appended this. since the method is a non-static class method. * only add background-image if value isnt null * simplifyed limits validation * clean up * no need to execute a digest. * define the full model for new configurations * removed setDataFromBlockModel and general clean up and added documentation * default size should be medium * use retriveValuesFrom method to transfer data. * ability to disable an navigation item * createElementTypeAndCallback working again for settings. * still have the ability to retrive a scaffold model by alias, since we are still using alias in clipboard service. * disable clipboard tab if no available paste options * ups, should stay as alias * disable clipboard when empty * use property alias for content add button * use a grey that can be seen on top of grey and on top of white. * some accessibility improvements * rename entry to block * appended ' and added space in Element Type * use background color for hover to corospond with active state * make nested content unsupported * Moving BlockEditorModelObject into its own file for Documentation purpose. Same goes for renaming BlockModel to BlockObject. and a lot of documentation written. * fix links in js docs * added a blocklistentryeditor for unsupported blocks * ability to retrive the $scope from UmbVariantContentEditors, needed for Block Editor to get a scope existing across variants and splitview. * Appending the block objects to layout, to share it across variants and in split-view. * removed trailing comma * Unsupported block * Dont copy unsupported blocks * use grey color for unsupported block * text correction * we dont have this fallback anymore * sort properties * Text change * css correction * use active to determine if an inline editor is expanded. To enable the inline editor to be expanded on creation. * using udi instead of key. * bringing the runtime block key back * live editing ability * live editing for settings data * call formSubmit before property editor are removed from DOM. Both for overlay-editing and inline-editing. Fire an postFormSubmitting event after formSubmitting event to let editors know that data could have been updated. * make sure settings object exists * only set active to false if it was false before opening the editor. * update test with new scope parameter * move destroy responsibility to blockObject * rename onDestroy to destroy * added some JS-Docs * correction jsDocs * Update ElementType Resource to not use hardcoded URL but to use the Umbraco.Sys.ServerVariables.umbracoUrls instead * Remove partially completed ConvertToElement migration, fixed in issue 7939 instead. * Remove external property editor migration * corrected naming of umbBlockListScopedBlock and umbBlockListBlock * correct ngdoc type * removed vscode specific configuration of karma * Finished Todo, gets name of documentType if copying all entities in an infinite editor * changed comment from TODO to something that explains the state. * stop tracking build output files. * rename files to match file name conventions * this should not happen. * remove dublicated code * rename requestCopyBlock to copyBlock * make sure images does not repeat. * scale thumbnail for block showcase * renamed blockcard.component to umb-block-card and moved it. * removed inline style * correct style location * corrected filepath * corrected file path * keep elementTypes up to date through the EventService. * mark Umbraco.BlockList as unsupported inside Nested Content * correct js docs name * remove comment * remove comment * remove unused controller * rename inline method name * corrected spelling mistake * remove not very used vars * make binding one-way * split in multiple lines * corrected default rendering * removing documentation that is relevant for developers of new block editors. this documentation will be transfered to Our documentation. * added danish translation * corrected blog to blok * Remove invalid using statement * use native forEach Co-authored-by: Niels Lyngsø <nsl@umbraco.dk> Co-authored-by: Benjamin Carleski <benjamin@proworks.com> Co-authored-by: Warren Buckley <warren@umbraco.com> Co-authored-by: Niels Lyngsø <nsl@umbraco.com> Co-authored-by: Niels Lyngsø <niels.lyngso@gmail.com> Co-authored-by: Claus <claus@claus.nu>
This was referenced Sep 18, 2020
|
If anyone finding this wants to get fixes for these issues before the PR is merged, as well as a fix for #7914 which prevents you from going straight from v7 to v8.6+, you can use the ProWorks.Umbraco8.Migrations package (with source code here). It includes fixes for both issues while the PRs for them are under review. |
|
Hello @benjaminc! A huge thanks for your contribution! We have taken the time to review it and while we are grateful for the work you have done, we have decided to close the PR. We have spent some time as a team, along with community members, weighing up the pros and cons of making changes to help with the migration process and given the status of Umbraco 8, we have decided to close the related PRs and instead, point our contributors towards this umbazing package by Proworks. You might notice that I am a robot but I'd like to reassure you that your PR was assessed by a team of real life people, during our CMS team workshop in October. Take a look at this article if you're interested in finding out how we went about these decisions. Any questions, as ever, please reach out. All the best! Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
This resolves the issue at #7939
Description
Add migrations for color picker pre-values, slider pre-values, and multiple-textstring pre-values. Also migrations to fix a couple pre-values that weren't migrated correctly on the grid, nested content, and multi-node tree picker. Document types used on nested content data types were marked as elements if elements hadn't been setup in the DB already. Finally, added a migration to update data embedded in nested content properties for checkbox lists, radio button lists and dropdowns.