Fixes U4 6510 - Norwegian labels, dictionary and language #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from original
It seems to be a check on the first 2 letters of the culture name and the filname, because nothing is translated when you switch to norwegian language. When changing the filename from no.xml to nb.xml, translations are applied
|
Wow, I don't think this ever worked correctly! Thanks! |
|
I guess this merge failed because I applied the renaming before the changes in #935 ? |
|
It didn't fail! :-) |
|
Ok, the pull request just didn't close like they usually does, and it says "This branch has conflicts that must be resolved" I also downloaded 7.4 BETA today and it seems the language file is still called "no.xml" |
|
Weird, looks like I messed up then! Will investigate after the holidays, thanks for letting me know! |
|
Alright, fixed this all up now and 7.3.5+ will have the new translations and the nb.xml file by default, thanks again! |
|
Perfect 👍 Any chance #932 could be considered for 7.3.5? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how localization works in Umbraco, but it seems to be a comparing of the first 2 letters of the culture name and the filname, because nothing is translated when you switch to Norwegian
language. When changing the filename from no.xml to nb.xml, translations are applied