U4-7312-2 #937
U4-7312-2 #937
Conversation
…and fileupload.controller.js Changed ImageController.GetBigThumbnail to redirect Changed thumbnail paths to include rnd equal to UpdateDate
| /// </remarks> | ||
| public HttpResponseMessage GetResized(string imagePath, int width) | ||
| { | ||
| var media = Services.MediaService.GetMediaByPath( imagePath ); |
There was a problem hiding this comment.
@Shazwazza - I think there is a problem here.
The Services.MediaService.GetMediaByPath method expects the media path to be stored in a property type with alias 'umbracoFile'.
However the Umbraco.UploadField property editor uses the alias 'fileUpload'
Could this method by changed to support other aliases?
There was a problem hiding this comment.
Nevermind, I just realized that the GetBigThumbnail method needs to work for non-media files. Will provide a fix for that.
|
I have tested to following:
|
|
This commit conflicts witch changes in ImagesController: This pull request delegates thumbnail generation to Image Processor and therefore any logic based on file extension should not be needed here? |
…U4-7312-2 Conflicts: src/Umbraco.Web/Editors/ImagesController.cs - Removed changes from upstream
|
@davidwincent yup i'll review this PR, the other commit, the impact it has on 7.4 final |
|
|
||
| return result; | ||
| var response = Request.CreateResponse( HttpStatusCode.Found ); | ||
| response.Headers.Location = new Uri( string.Format( "{0}?rnd={1}&width={2}", imagePath, string.Format( "{0:yyyyMMddHHmmss}", System.IO.File.GetLastWriteTime( fullOrgPath ) ), width ), UriKind.Relative ); |
There was a problem hiding this comment.
This won't work unfortunately. The purpose of IFileSystem (i.e. the mediaFileSystem) is to abstract away the physical file system so that media can be stored anywhere (i.e. Azure blob storage). We cannot mix IFileSystem with the physical file system (i.e. System.IO.File), you need to use the mediaFileSystem to get whatever information you need about the file.
There was a problem hiding this comment.
If you can push a fix for this, I can test and try to get this in to 7.4.0 which is due for release very early Jan.
There was a problem hiding this comment.
Will look into a fix soon.
|
Removed dependency to System.IO.File |
See http://issues.umbraco.org/issue/U4-7312