Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vertical align content of UUI-Button anchor tag #254

Merged
merged 2 commits into from
Jun 29, 2022
Merged

fix: vertical align content of UUI-Button anchor tag #254

merged 2 commits into from
Jun 29, 2022

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Jun 29, 2022 •
edited by iOvergaard
Loading

Use flex-box (flex-inline) to vertical align content of UUI-Button anchor tag

Fixes #253

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@iOvergaard iOvergaard merged commit 319312c into v1/dev Jun 29, 2022
@iOvergaard iOvergaard deleted the v1/bugfix/uui-button-use-flexbox branch June 29, 2022 13:19
@iOvergaard iOvergaard added the bug Something isn't working label Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uui-button slot content is not centered when it renders anchot tag instead of button
2 participants
@nielslyngsoe @iOvergaard