Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/dispatching of events twice #292

Merged
merged 8 commits into from
Aug 10, 2022
Merged

Bugfix/dispatching of events twice #292

merged 8 commits into from
Aug 10, 2022

Conversation

loivsen
Copy link
Contributor

@loivsen loivsen commented Aug 10, 2022 •
edited
Loading

Description

bubbles set to true on default
and a lot of e.stopPropagation() for where events could maybe clash with native events

Theres some other dispatch of events (forexample in combobox's method _onclose has a search event dispatched. Would we need a stopPropagation here as well? I assumed not because I dont think it had anything to do with native events, but please let me know if I'm wrong here.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

iOvergaard
iOvergaard requested changes Aug 10, 2022
View reviewed changes
packages/uui-input/lib/uui-input.element.ts Outdated Show resolved Hide resolved
packages/uui-radio/lib/uui-radio-group.element.ts Show resolved Hide resolved
packages/uui-radio/lib/uui-radio-group.element.ts Outdated Show resolved Hide resolved
packages/uui-slider/lib/uui-slider.element.ts Outdated Show resolved Hide resolved
@iOvergaard iOvergaard added the bug Something isn't working label Aug 10, 2022
@iOvergaard iOvergaard linked an issue Aug 10, 2022 that may be closed by this pull request
uui-input components dispatches the input event twice. #283
Closed
@iOvergaard iOvergaard merged commit 901da47 into v1/dev Aug 10, 2022
@iOvergaard iOvergaard deleted the bugfix/dispatching-of-events-twice branch August 10, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uui-input components dispatches the input event twice.
2 participants
@loivsen @iOvergaard