-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/popover container firefox polyfill #628
Feature/popover container firefox polyfill #628
Conversation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-628.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-628.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-628.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-628.westeurope.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-628.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-628.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-628.westeurope.azurestaticapps.net |
2 similar comments
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-628.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-628.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-628.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-628.westeurope.azurestaticapps.net |
Not sure if it worth trying this project: Based on the demos it seems to work in Firefox: but it has some Caveats like native
|
…-container-firefox-polyfill
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-628.westeurope.azurestaticapps.net |
@bjarnef I've looked at the oddbird polyfill, and I can't get it to work properly in bigger applications, such as New Backoffice, due to z-index issues. |
…-container-firefox-polyfill
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-628.westeurope.azurestaticapps.net |
…-container-firefox-polyfill
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We agreed on the following:
- Clean up the popover container story (remove test)
- Change experimental warning to say that it now will work in all browsers due to a polyfill (but it is still experimental)
- Make it 1-1 with the old popover stories
- Add deprecation warnings to the old Popover element
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-628.westeurope.azurestaticapps.net |
…-container-firefox-polyfill
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-628.westeurope.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-628.westeurope.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-628.westeurope.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-628.westeurope.azurestaticapps.net |
Description
This PR introduces a polyfill for the popover container, enhancing its functionality to ensure proper compatibility with Firefox browsers. The polyfill has been integrated in a minimally intrusive manner, preserving the original structure of the popover container element. Removing just one line of code from the popover container element will effectively disable the polyfill.
This polyfill supports:
Also edits findAncestorByAttributeValue in uui-base, so that it also checks shadow root hosts
Known bugs:
Types of changes
Motivation and context
Currently, due to the lack of support for the new popover API in Firefox, we are unable to utilize the popover container. With this polyfill, the popover container can now offer a user experience in Firefox that is nearly on par with that of supported browsers.