Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dont show a link when no href is supplied #797

Merged
merged 6 commits into from
May 23, 2024

Conversation

JesmoDev
Copy link
Contributor

Makes breadcrumbs render as a span instead of a tag when no href is supplied.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@iOvergaard iOvergaard added the bug Something isn't working label May 23, 2024
@iOvergaard iOvergaard merged commit 658b6a6 into v1/contrib May 23, 2024
8 of 10 checks passed
@iOvergaard iOvergaard deleted the bugfix/breadcrumbs-link branch May 23, 2024 13:35
@iOvergaard iOvergaard changed the title Bugfix: Dont show a link when no href is supplied fix: Dont show a link when no href is supplied May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants