Skip to content
This repository has been archived by the owner on Dec 13, 2021. It is now read-only.

DefaultProcessorType - makes static and adds lock #224

Merged
merged 2 commits into from
Sep 5, 2017
Merged

DefaultProcessorType - makes static and adds lock #224

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
489d2e4
DefaultProcessorType - makes static and adds lock
leekelleher Sep 4, 2017
182bb82
GetDefaultProcessorType - removed lock (for reading)
leekelleher Sep 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/Our.Umbraco.Ditto/ComponentModel/Processors/DittoProcessorRegistry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@ internal class DittoProcessorRegistry
/// <summary>
/// The default processor type, (defaults to `UmbracoProperty`).
/// </summary>
private Type DefaultProcessorType = typeof(UmbracoPropertyAttribute);
private static Type DefaultProcessorType = typeof(UmbracoPropertyAttribute);

/// <summary>
/// The lock object to make DefaultProcessorType access thread safe.
/// </summary>
private static readonly object DefaultProcessorTypeLock = new object();

/// <summary>
/// Prevents a default instance of the <see cref="DittoProcessorRegistry"/> class from being created.
Expand Down Expand Up @@ -57,7 +62,10 @@ public static DittoProcessorRegistry Instance
public void RegisterDefaultProcessorType<TProcessorAttributeType>()
where TProcessorAttributeType : DittoProcessorAttribute, new()
{
this.DefaultProcessorType = typeof(TProcessorAttributeType);
lock (DefaultProcessorTypeLock)
{
DefaultProcessorType = typeof(TProcessorAttributeType);
}
}

/// <summary>
Expand Down Expand Up @@ -108,7 +116,7 @@ public Type GetDefaultProcessorType(Type objectType)
return attr.ProcessorType;
}

return this.DefaultProcessorType;
return DefaultProcessorType;
}

/// <summary>
Expand Down