This repository has been archived by the owner on Dec 13, 2021. It is now read-only.
Deprecate PropertyDescriptor in Contexts #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason we're using the `PropertyDescriptor` is due to Ditto original use of TypeConverters. When we rolled up the TypeConverters and ValueResolvers, we'd kept `PropertyDescriptor` available. However the use of reflection in Ditto's internals, there is an additional call made to exclusively get the `PropertyDescriptor`. If we switch this to use the `PropertyInfo`, (which we already have a local reference to), then this can be used to access any metadata about the property itself. So not to make this a rough breaking-change, I'd left the `PropertyDescriptor` property available on the Contexts, so not to completely ruin the developer experience. I added an obsolete/warning message saying that it would be removed in a future release. Does anyone foresee any downsides with this approach?
|
Sounds good to me 👍 |
|
PropertyDescripters are slow, ditch em when you can. |
|
Thanks guys, merged it in! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason we're using the
PropertyDescriptoris due to Ditto original use of TypeConverters.When we rolled up the TypeConverters and ValueResolvers, we'd kept
PropertyDescriptoravailable.However the use of reflection in Ditto's internals, there is an additional call made to exclusively get the
PropertyDescriptor. If we switch this to use thePropertyInfo, (which we already have a local reference to), then this can be used to access any metadata about the property itself.So not to make this a rough breaking-change, I'd left the
PropertyDescriptorproperty available on the Contexts, so not to completely ruin the developer experience. I added an obsolete/warning message saying that it would be removed in a future release.Does anyone foresee any downsides with this approach?