Skip to content
This repository has been archived by the owner on Dec 13, 2021. It is now read-only.

Deprecate PropertyDescriptor in Contexts #233

Merged
merged 1 commit into from
Jan 9, 2018

Commits on Jan 9, 2018

  1. Deprecate PropertyDescriptor in Contexts

    The reason we're using the `PropertyDescriptor` is due to Ditto original use of TypeConverters.
    When we rolled up the TypeConverters and ValueResolvers, we'd kept `PropertyDescriptor` available.
    
    However the use of reflection in Ditto's internals, there is an additional call made to exclusively get the `PropertyDescriptor`.
    If we switch this to use the `PropertyInfo`, (which we already have a local reference to), then this can be used to access any metadata about the property itself.
    
    So not to make this a rough breaking-change, I'd left the `PropertyDescriptor` property available on the Contexts, so not to completely ruin the developer experience.  I added an obsolete/warning message saying that it would be removed in a future release.
    
    Does anyone foresee any downsides with this approach?
    leekelleher committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    b5e5761 View commit details
    Browse the repository at this point in the history