Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix host package dependencies problem #1109

Merged
merged 2 commits into from Jun 18, 2022
Merged

fix: fix host package dependencies problem #1109

merged 2 commits into from Jun 18, 2022

Conversation

binyellow
Copy link
Contributor

🤔 这个变动的性质是?/ What is the nature of this change?

  • 新特性提交 / New feature
  • bug 修复 / Fix bug
  • 样式优化 / Style optimization
  • 代码风格优化 / Code style optimization
  • 性能优化 / Performance optimization
  • 构建优化 / Build optimization
  • 网站、文档、Demo 改进 / Website, documentation, demo improvements
  • 重构代码或样式 / Refactor code or style
  • 测试相关 / Test related
  • 其他 / Other

🔗 相关 Issue / Related Issue

#1105

💡 需求背景和解决方案 / Background or solution

在lerna场景下codeSandbox的dependencies依赖解析错误,导致在线demo打开都报错
报错demo链接
其他pro-components的在线demo都会报错
已在pro-components下npm link测试通过

📝 更新日志 / Changelog

Language Changelog
🇺🇸 English Fixed the dependency parsing error of codeSandbox in the lerna scenario, resulting in the lack of dependencies in the online demo opening report
🇨🇳 Chinese 修复在lerna场景下codeSandbox的dependencies依赖解析错误,导致在线demo打开报缺少依赖问题

@vercel
Copy link

vercel bot commented Jun 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dumi ❌ Failed (Inspect) Jun 15, 2022 at 7:51AM (UTC)

@github-actions
Copy link

github-actions bot commented Jun 15, 2022

🎊 PR Preview has been successfully built and deployed to https://dumi-preview-pr-1109.surge.sh

@github-actions
Copy link

github-actions bot commented Jun 15, 2022

🎊 PR Mobile Preview has been successfully built and deployed to https://dumi-mobile-preview-pr-1109.surge.sh

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #1109 (1e5164d) into master (ab17f8c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1109      +/-   ##
==========================================
+ Coverage   95.05%   95.06%   +0.01%     
==========================================
  Files         119      119              
  Lines        2931     2937       +6     
  Branches     1002      999       -3     
==========================================
+ Hits         2786     2792       +6     
  Misses        141      141              
  Partials        4        4              
Impacted Files Coverage Δ
...s/preset-dumi/src/transformer/demo/dependencies.ts 100.00% <100.00%> (ø)
packages/preset-dumi/src/utils/moduleResolver.ts 93.18% <100.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab17f8c...1e5164d. Read the comment docs.

@binyellow
Copy link
Contributor Author

老哥 cc @PeachScript

@PeachScript PeachScript merged commit 202b2c8 into umijs:master Jun 18, 2022
Copy link
Member

@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants