Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to show line number for SourceCode (#1639) #1654

Merged
merged 8 commits into from
May 19, 2023

Conversation

KuangPF
Copy link
Contributor

@KuangPF KuangPF commented May 11, 2023

🤔 这个变动的性质是?/ What is the nature of this change?

  • 新特性提交 / New feature
  • bug 修复 / Fix bug
  • 样式优化 / Style optimization
  • 代码风格优化 / Code style optimization
  • 性能优化 / Performance optimization
  • 构建优化 / Build optimization
  • 网站、文档、Demo 改进 / Website, documentation, demo improvements
  • 重构代码或样式 / Refactor code or style
  • 测试相关 / Test related
  • 其他 / Other

🔗 相关 Issue / Related Issue

1639

💡 需求背景和解决方案 / Background or solution

基于 themeConfig.showLineNum值判断是否添加代码行号。

📝 更新日志 / Changelog

Language Changelog
🇺🇸 English feat: add line mum for source code content
🇨🇳 Chinese feat: 代码块增加行号展示

@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dumi ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2023 10:50am

@PeachScript
Copy link
Member

方便贴个亮色、暗色模式下的预览截图吗

@KuangPF
Copy link
Contributor Author

KuangPF commented May 11, 2023

light theme
light-theme

dark theme
dark-theme

@PeachScript
Copy link
Member

与 master 的冲突需要处理下哈

@KuangPF
Copy link
Contributor Author

KuangPF commented May 15, 2023

冲突解决了,调整了下 css 样式,铺满了整行:
dark-base
dark-line-number

docs/theme/default.md Outdated Show resolved Hide resolved
@PeachScript PeachScript changed the title feat: add line mum for source code content(#1639) feat: support to show line number for SourceCode (#1639) May 18, 2023
Copy link
Member

@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants