Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

feat: build noClean #12

Merged
merged 2 commits into from
Jun 25, 2022
Merged

feat: build noClean #12

merged 2 commits into from
Jun 25, 2022

Conversation

xiaohuoni
Copy link
Member

@xiaohuoni xiaohuoni commented Jun 25, 2022 •
edited
Loading

image
image

@codecov
Copy link

codecov bot commented Jun 25, 2022 •
edited
Loading

Codecov Report

Merging #12 (02ca2b8) into master (edf71ee) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   93.67%   93.69%   +0.01%     
==========================================
  Files          27       27              
  Lines         632      634       +2     
  Branches      144      145       +1     
==========================================
+ Hits          592      594       +2     
  Misses         37       37              
  Partials        3        3
Impacted Files Coverage Δ
src/builder/index.ts 100.00% <100.00%> (ø)
src/commands/build.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edf71ee...02ca2b8. Read the comment docs.

@xiaohuoni xiaohuoni mentioned this pull request Jun 25, 2022
Closed
71 tasks
PeachScript
PeachScript reviewed Jun 25, 2022
View reviewed changes
Copy link
Member

@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

试了下 --no-clean 会被转换为 clean: false，所以把写法调整了下

src/commands/build.ts Outdated Show resolved Hide resolved
src/builder/index.ts Outdated Show resolved Hide resolved
src/builder/index.ts Outdated Show resolved Hide resolved
examples/normal/package.json Outdated Show resolved Hide resolved
@PeachScript PeachScript merged commit 91bbd3c into master Jun 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the feat-build-noClean branch June 25, 2022 10:33
PeachScript added a commit to umijs/father that referenced this pull request Aug 26, 2022
@xiaohuoni @PeachScript
feat: build support --no-clean arg (umijs/father-next#12)
7168330 
* feat: build noClean

* Apply suggestions from code review

Co-authored-by: xiaohuoni <chen.xiaocong2@iwhalecloud.com>
Co-authored-by: Peach <scdzwyxst@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PeachScript PeachScript PeachScript approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaohuoni @PeachScript