🐛 should not change currentScript if it not configurable (#1470)

umijs · May 25, 2021 · ad9a59c · ad9a59c · github-actions · May 25, 2021
1 parent fd289f2
commit ad9a59c
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/src/sandbox/patchers/dynamicAppend/common.ts b/src/sandbox/patchers/dynamicAppend/common.ts
@@ -219,12 +219,18 @@ function getOverwrittenAppendChildOrInsertBefore(opts: {
               fetch,
               strictGlobal,
               beforeExec: () => {
-                Object.defineProperty(document, 'currentScript', {
-                  get(): any {
-                    return element;
-                  },
-                  configurable: true,
-                });
+                const isCurrentScriptConfigurable = () => {
+                  const descriptor = Object.getOwnPropertyDescriptor(document, 'currentScript');
+                  return !descriptor || descriptor.configurable;
+                };
+                if (isCurrentScriptConfigurable()) {
+                  Object.defineProperty(document, 'currentScript', {
+                    get(): any {
+                      return element;
+                    },
+                    configurable: true,
+                  });
+                }
               },
               success: () => {
                 manualInvokeElementOnLoad(element);