Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Make sure singular is always false when using loadMicroApp #1168

Merged
merged 4 commits into from Dec 24, 2020
Merged

🐛 Make sure singular is always false when using loadMicroApp #1168

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c02ba7
🐛 Make sure singular is always false when using loadMicroApp
Dec 20, 2020
850441c
🐛 fix singular's value when using loadMicroApp
gongshun Dec 21, 2020
4908c9b
remove extra spaces
Dec 23, 2020
6c2fc97
Merge branch 'master' into fix/singular
gongshun Dec 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/apis.ts
View file
Open in desktop
Expand Up @@ -79,7 +79,8 @@ export function loadMicroApp<T extends ObjectType>(
* the micro app would not load and evaluate its lifecycles again
*/
const memorizedLoadingFn = async (): Promise<ParcelConfigObject> => {
const { $$cacheLifecycleByAppName } = configuration ?? frameworkConfiguration;
const userConfiguration = configuration ?? { ...frameworkConfiguration, singular: false };
const { $$cacheLifecycleByAppName } = userConfiguration;
const container = 'container' in app ? app.container : undefined;

if (container) {
Expand All @@ -96,7 +97,7 @@ export function loadMicroApp<T extends ObjectType>(
}
}

const parcelConfigObjectGetterPromise = loadApp(app, configuration ?? frameworkConfiguration, lifeCycles);
const parcelConfigObjectGetterPromise = loadApp(app, userConfiguration, lifeCycles);

if (container) {
if ($$cacheLifecycleByAppName) {
Expand Down