🐛 Make sure singular is always false when using loadMicroApp #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuitos
requested changes
Dec 21, 2020
kuitos
requested changes
Dec 23, 2020
|
这个我记得是有关联的 issue？有的话加到 pr 描述里关联 close 一下 |
空格去掉了，没有关联issue，在钉钉群里有人提出来的 |
|
合一下 master 分支，lint 问题修复了 |
合并了 |
kuitos
approved these changes
Dec 24, 2020
kuitos
pushed a commit
that referenced
this pull request
May 29, 2022
…App (#1168) Co-authored-by: gongshun <gongshun@gridsum.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change
如果先使用
start函数，默认的singular值会变成true，再使用loadMicroApp，singular就还是true