-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 manual invoke single-spa start function for parcels and set urlRerouteOnly true as default #1414
Conversation
…uteOnly true as default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
文档是否需要补充一下
你指哪一块的文档?urlRerouteOnly 这个吗? |
是的 |
这个感觉不用透出了,如果默认值不会对以前的行为造成影响的话,那用户也不需要感知到这个配置 |
angular v11 主应用里面引用2.4.1,会导致在主应用里面跳转(使用routerLink指令)子应用(angular v11)无效,原因就是 2.4.1里面的 start() 方法中默认 {urlRerouteOnly: true} 了。 |
大部分情况是不需要 urlRerouteOnly: true 的,你如果需要的话, start 的时候是可以配置的 |
是的,在angular v11环境中升级到2.4.1需要 start({urlRerouteOnly: false}); 既然大部分情况是不需要 urlRerouteOnly: true 的, 为什么2.4.1中 urlRerouteOnly 默认值为true? |
应该是大部分情况不需要设置 urlRerouteOnly: false 吧? @gongshun |
对,说错了。 |
#1071 |
…uteOnly true as default (#1414)
manual invoke single-spa start function for parcels
unlock single-spa
set urlRerouteOnly to true as default
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)