feat(loader): pass single-spa props to frameworkLifeCycles #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lifecycle function 里的第一个参数 app 里应该是有 props 的，app.props 可以直接取到 |
kuitos
reviewed
Mar 10, 2021
| @@ -44,9 +44,10 @@ function execHooksChain<T extends ObjectType>( | |||
| hooks: Array<LifeCycleFn<T>>, | |||
| app: LoadableApp<T>, | |||
There was a problem hiding this comment.
app里的props不包含single-spa生命周期里传进来的props
There was a problem hiding this comment.
single-spa 里那些方法是供子应用调用的，主应用来用有点奇怪。
主应用要自己 mount/unmount 子应用的话，可以直接通过 microApp.unmount 的方式去做
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change