refactor: 🔥 remove deep clone (#12324)

* refactor: 🔥 remove deep clone * refactor: 🔥 remove outputfiles in defination
umijs · Apr 29, 2024 · 3e291e5 · 3e291e5
1 parent 575590e
commit 3e291e5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 13 deletions.
diff --git a/packages/core/src/service/service.ts b/packages/core/src/service/service.ts
@@ -52,7 +52,7 @@ export class Service {
     >;
     framework?: IFrameworkType;
     prepare?: {
-      buildResult: BuildResult;
+      buildResult: Omit<BuildResult, 'outputFiles'>;
       fileImports?: Record<string, Declaration[]>;
     };
     mpa?: {

diff --git a/packages/preset-umi/src/features/prepare/prepare.ts b/packages/preset-umi/src/features/prepare/prepare.ts
@@ -1,12 +1,6 @@
 import type { BuildResult } from '@umijs/bundler-utils/compiled/esbuild';
 import type { Declaration } from '@umijs/es-module-parser';
-import {
-  aliasUtils,
-  importLazy,
-  isJavaScriptFile,
-  lodash,
-  logger,
-} from '@umijs/utils';
+import { aliasUtils, importLazy, isJavaScriptFile, logger } from '@umijs/utils';
 import path from 'path';
 import { addUnWatch } from '../../commands/dev/watch';
 import { IApi, IOnGenerateFiles } from '../../types';
@@ -20,11 +14,12 @@ export default (api: IApi) => {
     buildResult: BuildResult;
     fileImports?: Record<string, Declaration[]>;
   }) {
-    const buildResult: BuildResult = lodash.cloneDeep(prepareData.buildResult);
-    (buildResult.outputFiles || []).forEach((file) => {
-      // @ts-ignore
-      delete file?.contents;
-    });
+    const buildResult: BuildResult = {
+      ...prepareData.buildResult,
+      // we don't need output file in prepare stage
+      outputFiles: undefined,
+    };
+
     const nextFileImports =
       prepareData.fileImports ?? api.appData.prepare?.fileImports;
     api.appData.prepare = {