Revert "chore: isGTEReact16 > shouldUseAutomaticRuntime"

This reverts commit 90e5c9d.
umijs · Mar 21, 2024 · 52baa94 · 52baa94
1 parent 90e5c9d
commit 52baa94
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/packages/preset-umi/src/commands/build.ts b/packages/preset-umi/src/commands/build.ts
@@ -97,12 +97,12 @@ umi build --clean
           umi: join(api.paths.absTmpPath, 'umi.ts'),
         },
       });
-      const shouldUseAutomaticRuntime =
+      const isGTEReact16 =
         api.appData.react?.version &&
         semver.gte(api.appData.react.version, '16.14.0');
       const opts = {
         react: {
-          runtime: shouldUseAutomaticRuntime ? 'automatic' : 'classic',
+          runtime: isGTEReact16 ? 'automatic' : 'classic',
         },
         config: api.config,
         cwd: api.cwd,

diff --git a/packages/preset-umi/src/commands/dev/dev.ts b/packages/preset-umi/src/commands/dev/dev.ts
@@ -348,12 +348,12 @@ PORT=8888 umi dev
         },
       });
 
-      const shouldUseAutomaticRuntime =
+      const isGTEReact16 =
         api.appData.react?.version &&
         semver.gte(api.appData.react.version, '16.14.0');
       const opts: any = {
         react: {
-          runtime: shouldUseAutomaticRuntime ? 'automatic' : 'classic',
+          runtime: isGTEReact16 ? 'automatic' : 'classic',
         },
         config: api.config,
         pkg: api.pkg,

diff --git a/packages/preset-umi/src/commands/dev/getBabelOpts.ts b/packages/preset-umi/src/commands/dev/getBabelOpts.ts
@@ -3,15 +3,15 @@ import { IApi } from '../../types';
 
 export async function getBabelOpts(opts: { api: IApi }) {
   // TODO: 支持用户自定义
-  const shouldUseAutomaticRuntime = semver.gte(opts.api.appData.react.version, '16.14.0');
+  const isGTEReact16 = semver.gte(opts.api.appData.react.version, '16.14.0');
   const babelPresetOpts = await opts.api.applyPlugins({
     key: 'modifyBabelPresetOpts',
     initialValue: {
       presetEnv: {},
       presetReact: {
-        runtime: shouldUseAutomaticRuntime ? 'automatic' : 'classic',
+        runtime: isGTEReact16 ? 'automatic' : 'classic',
         // importSource cannot be set when runtime is classic
-        ...(shouldUseAutomaticRuntime ? {} : { importSource: undefined }),
+        ...(isGTEReact16 ? {} : { importSource: undefined }),
       },
       presetTypeScript: {},
       pluginTransformRuntime: {},