feat: support disable hmr with env variable HMR=none

umijs · Mar 9, 2020 · b3069fb · b3069fb
1 parent 0879461
commit b3069fb
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/docs/docs/env-variables.md b/docs/docs/env-variables.md
@@ -89,6 +89,10 @@ $ FORK_TS_CHECKER=1 umi dev
 $ FRIENDLY_ERROR=none umi dev
 ```
 
+### HMR
+
+设为 `none` 时禁用代码热更新功能。
+
 ### HTML
 
 设为 `none` 时不输出 HTML，`umi build` 时有效。

diff --git a/docs/docs/env-variables.zh-CN.md b/docs/docs/env-variables.zh-CN.md
@@ -84,6 +84,10 @@ $ FORK_TS_CHECKER=1 umi dev
 $ FRIENDLY_ERROR=none umi dev
 ```
 
+### HMR
+
+设为 `none` 时禁用代码热更新功能。
+
 ### HTML
 
 设为 `none` 时不输出 HTML，`umi build` 时有效。

diff --git a/packages/bundler-webpack/src/getConfig/getConfig.ts b/packages/bundler-webpack/src/getConfig/getConfig.ts
@@ -335,9 +335,11 @@ export default async function getConfig(
   webpackConfig.when(
     isDev,
     webpackConfig => {
-      webpackConfig
-        .plugin('hmr')
-        .use(bundleImplementor.HotModuleReplacementPlugin);
+      if (hot) {
+        webpackConfig
+          .plugin('hmr')
+          .use(bundleImplementor.HotModuleReplacementPlugin);
+      }
     },
     webpackConfig => {
       // don't emit files if have error

diff --git a/packages/preset-built-in/src/plugins/commands/buildDevUtils.ts b/packages/preset-built-in/src/plugins/commands/buildDevUtils.ts
@@ -41,7 +41,7 @@ export async function getBundleAndConfigs({
         env,
         type,
         port,
-        hot: type === ConfigType.csr,
+        hot: type === ConfigType.csr && process.env.HMR !== 'none',
         entry: {
           umi: join(api.paths.absTmpPath!, 'umi.ts'),
         },