fix(preset-umi): wrong async script mark when enable exportStatic (#1…

…2216)
umijs · Mar 21, 2024 · eb3ea75 · eb3ea75
1 parent f03915a
commit eb3ea75
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/packages/preset-umi/src/features/exportStatic/exportStatic.ts b/packages/preset-umi/src/features/exportStatic/exportStatic.ts
@@ -148,15 +148,21 @@ export default (api: IApi) => {
     const { publicPath } = api.config;
     const htmlData = api.appData.exportHtmlData;
     const htmlFiles: { path: string; content: string }[] = [];
+    const { markupArgs: defaultMarkupArgs } = opts;
+    let asyncMarkupArgs: typeof defaultMarkupArgs;
 
     for (const { file, route, prerender } of htmlData) {
-      let { markupArgs } = opts;
+      let markupArgs = defaultMarkupArgs;
+
+      // mark async for the scripts of pre-rendered html
       if (api.config.ssr && prerender) {
-        markupArgs.scripts.forEach((script: any) => {
-          if (script.src) {
-            script.async = true;
-          }
-        });
+        // copy args to avoid affect original object
+        markupArgs = asyncMarkupArgs ??= {
+          ...markupArgs,
+          scripts: markupArgs.scripts.map((script: any) =>
+            script.src ? { ...script, async: true } : script,
+          ),
+        };
       }
 
       // handle relative publicPath, such as `./`