Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: PullRequest Checker #10319

Merged
merged 12 commits into from
Feb 7, 2023
Merged

ci: PullRequest Checker #10319

merged 12 commits into from
Feb 7, 2023

Conversation

txp1035
Copy link
Member

@txp1035 txp1035 commented Jan 19, 2023

作用

这是一个机器人,非 doc pr 被合并时,发个消息 xxx(用于邀请新人进 umi contributor 群)

消息测试

感谢 PR。如果有兴趣一起参与维护 Umi,可先用钉钉扫下方二维码(注明 github id)加我钉钉,然后我会拉到群里。

@vercel
Copy link

vercel bot commented Jan 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
umi ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2023 at 3:17AM (UTC)

@txp1035 txp1035 changed the title ci: PullRequest Checker [wip]ci: PullRequest Checker Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 29.29% // Head: 29.29% // No change to project coverage 👍

Coverage data is based on head (2f62d8e) compared to base (3c78dbe).
Patch has no changes to coverable lines.

❗ Current head 2f62d8e differs from pull request most recent head c968dc5. Consider uploading reports for the commit c968dc5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10319   +/-   ##
=======================================
  Coverage   29.29%   29.29%           
=======================================
  Files         445      445           
  Lines       13006    13006           
  Branches     3178     3178           
=======================================
  Hits         3810     3810           
  Misses       8592     8592           
  Partials      604      604           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@txp1035
Copy link
Member Author

txp1035 commented Jan 19, 2023

@txp1035
Copy link
Member Author

txp1035 commented Jan 19, 2023

缺一张图片 #10320

@txp1035 txp1035 changed the title [wip]ci: PullRequest Checker ci: PullRequest Checker Jan 19, 2023
txp1035 and others added 2 commits January 19, 2023 20:42
Co-authored-by: 咲奈Sakina <59400654+fz6m@users.noreply.github.com>
@txp1035 txp1035 requested a review from fz6m January 19, 2023 13:09
@txp1035
Copy link
Member Author

txp1035 commented Jan 31, 2023

@sorrycc 有空看下

@sorrycc
Copy link
Member

sorrycc commented Jan 31, 2023

再加个条件,如果已经是 contributors 的,不要再提醒,contributors 列表可以找个地方维护,放在项目根目录也可以。

@txp1035
Copy link
Member Author

txp1035 commented Feb 2, 2023

image
有6个人id没找到。这个id要check下,我按照群里的人来的,活跃的yingci的id我改了其他的在排行里找不到可能要群里的人来check

@txp1035 txp1035 requested a review from fz6m February 2, 2023 12:46
@fz6m
Copy link
Member

fz6m commented Feb 2, 2023

用这个 api 获取 contributors ,感觉不用自己维护。

然后在用这个 https://github.com/actions/github-script actions 写逻辑 return 出来的值作为 output 给最后用感觉会更好。

@txp1035
Copy link
Member Author

txp1035 commented Feb 3, 2023

用这个 api 获取 contributors ,感觉不用自己维护。

然后在用这个 https://github.com/actions/github-script actions 写逻辑 return 出来的值作为 output 给最后用感觉会更好。

这个不能获取到钉钉的人员,这个工具的目的是邀请钉钉之外的人,以前贡献过但是可能没有邀请也需要发消息

@txp1035
Copy link
Member Author

txp1035 commented Feb 3, 2023

image

其他成员都check过一遍了,目前还剩、余化、人优,还没有通过好友 @sorrycc 认识的话加下?看起来是蚂蚁的同学

@txp1035 txp1035 mentioned this pull request Feb 6, 2023
68 tasks
Co-authored-by: chencheng (云谦) <sorrycc@gmail.com>
@sorrycc sorrycc merged commit 39fcb51 into umijs:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants