fix: mpa resolve error on Windows #10382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
这个是啥问题，是不是把 |
Codecov ReportBase: 29.29% // Head: 29.29% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #10382 +/- ##
==========================================
- Coverage 29.29% 29.29% -0.01%
==========================================
Files 445 445
Lines 13005 13006 +1
Branches 3178 3178
==========================================
Hits 3810 3810
- Misses 8591 8592 +1
Partials 604 604
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
我搞错了，跟那个 issues 和 winPath 无关，是我这边出现了新的错误，根据报错信息修了一下 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
fz6m
reviewed
Feb 2, 2023
| @@ -73,6 +73,7 @@ import * as x from "${winPath(args.path)}"; | |||
| ret = x.${opts.exportName} || {}; | |||
| `, | |||
| loader: 'ts', | |||
| resolveDir: args.path.slice(0, args.path.lastIndexOf('/')), | |||
There was a problem hiding this comment.
import { dirname } from 'path'
dirname(args.path)
Co-Authored-By: 咲奈Sakina <59400654+fz6m@users.noreply.github.com>
fz6m
approved these changes
Feb 3, 2023
Closed
sorrycc
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在
examples/mpa里 dev 报如下错误：此 PR 尝试修复。