Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logger): logger file should in package.json dir #10416

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

fz6m
Copy link
Member

@fz6m fz6m commented Feb 4, 2023

近日发现,只要是用 umi run / umi --help 都会生成日志到当前目录的 node_modules/.cache 下,正确的位置应该是和最近的 package.json 同级,而不是无脑在 cwd 生成。

@vercel
Copy link

vercel bot commented Feb 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
umi ⬜️ Ignored (Inspect) Feb 4, 2023 at 9:12PM (UTC)

@codecov
Copy link

codecov bot commented Feb 4, 2023

Codecov Report

Base: 29.29% // Head: 29.33% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (d42ce22) compared to base (3c78dbe).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10416      +/-   ##
==========================================
+ Coverage   29.29%   29.33%   +0.03%     
==========================================
  Files         445      445              
  Lines       13006    13013       +7     
  Branches     3178     3179       +1     
==========================================
+ Hits         3810     3817       +7     
  Misses       8592     8592              
  Partials      604      604              
Impacted Files Coverage Δ
packages/utils/src/logger.ts 33.33% <100.00%> (+8.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sorrycc sorrycc merged commit 3b64c39 into umijs:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants