Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: svgr fallback to file-loader when using big file #10796

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

fz6m
Copy link
Member

@fz6m fz6m commented Mar 20, 2023

fix #10794

目前 webpack5 没法原生做到又组件又 url 默认导出,所以只能用 url-loader fallback 到 file-loader 。

@vercel
Copy link

vercel bot commented Mar 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
umi ⬜️ Ignored (Inspect) Mar 20, 2023 at 2:23PM (UTC)

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (11fd7ec) 29.54% compared to head (833ca6d) 29.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10796   +/-   ##
=======================================
  Coverage   29.54%   29.54%           
=======================================
  Files         464      464           
  Lines       14008    14009    +1     
  Branches     3296     3296           
=======================================
+ Hits         4138     4139    +1     
  Misses       9179     9179           
  Partials      691      691           
Impacted Files Coverage Δ
packages/bundler-webpack/src/config/svgRules.ts 100.00% <ø> (ø)
packages/bundler-webpack/src/config/assetRules.ts 100.00% <100.00%> (ø)
packages/bundler-webpack/src/config/config.ts 75.20% <100.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sorrycc sorrycc merged commit 04c1cb8 into umijs:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] *.SVG file bypasses the inlineLimit restriction.
2 participants