-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: App locale no work #10969
fix: App locale no work #10969
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Size Change: +1.77 kB (0%) Total Size: 9.85 MB
ℹ️ View Unchanged
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #10969 +/- ##
==========================================
- Coverage 29.27% 29.26% -0.01%
==========================================
Files 478 479 +1
Lines 14328 14350 +22
Branches 3371 3373 +2
==========================================
+ Hits 4194 4200 +6
- Misses 9410 9426 +16
Partials 724 724
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
本地手动测试 example/with-antd-5
符合预期
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
原因是 locale 的 ConfigProvider 在 antd 的 App 内层导致的么,是不是控制这俩运行时插件的执行顺序也能解?
antd config 是在 i18n 的 provider 在设计上在 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
1、修改了一下 plugins 的 templates 目录,主要是 locale 的 tpl 放在 lib 里面,后来者不容易看到。而这几个插件存在相互影响的内容 。
2、修复了antd@5 App 的国际化无效的问题,Closes: #10944