Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): uppercase filename icons #10988

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

fz6m
Copy link
Member

@fz6m fz6m commented Apr 17, 2023

这里要解的一个问题是,如果用户使用了 中横线 - + 大写字母 的文件名,会报错。

但所有的云 icon 是没有这个问题的,因为云 icon 都是小写的。

fix #10920

cc @xiaohuoni

@vercel
Copy link

vercel bot commented Apr 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Apr 17, 2023 0:59am

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (db3a325) 29.23% compared to head (b8c67f9) 29.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10988   +/-   ##
=======================================
  Coverage   29.23%   29.23%           
=======================================
  Files         478      478           
  Lines       14352    14352           
  Branches     3379     3379           
=======================================
  Hits         4196     4196           
  Misses       9431     9431           
  Partials      725      725           
Impacted Files Coverage Δ
packages/preset-umi/src/features/icons/icons.ts 0.00% <ø> (ø)
packages/preset-umi/src/features/icons/svgr.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sorrycc sorrycc merged commit cda6001 into umijs:master Apr 19, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

umi开启icons配置,使用本地svg文件作为icon使用
2 participants