feat(server/routes): 扩展 createServerRoutes 方法，允许定制 route 的内容。 #11033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #11033 +/- ##
==========================================
- Coverage 29.21% 29.21% -0.01%
==========================================
Files 479 479
Lines 14385 14386 +1
Branches 3381 3382 +1
==========================================
Hits 4203 4203
- Misses 9455 9456 +1
Partials 727 727
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
sorrycc
approved these changes
Apr 25, 2023
fz6m
reviewed
Apr 25, 2023
| @@ -3,12 +3,14 @@ import { IRoute, IRoutesById } from './types'; | |||
| export function createServerRoutes(opts: { | |||
| routesById: IRoutesById; | |||
| parentId?: string; | |||
| createRoute?: (opts: { route: IRoute }) => any; | |||
There was a problem hiding this comment.
这个类型把下面的 route.xxx 使用的类型安全破坏了，得严谨一点，用 typeof createServerRoute
There was a problem hiding this comment.
但是用户传进来的 createRoute 返回值应该可以不是 createServerRoute 方法的返回值类型
There was a problem hiding this comment.
至少要拥有原对象的字段，逻辑会执行不下去，可以把返回值扩展一下：
export interface IRouteCustom extends IRoute {
[key: string]: any
}
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.