Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump esbuild -> 0.17.19 , use the new context api #11203

Merged
merged 6 commits into from
May 30, 2023
Merged

feat: bump esbuild -> 0.17.19 , use the new context api #11203

merged 6 commits into from
May 30, 2023

Conversation

Chastrlove
Copy link
Contributor

1.采用新的esbuild context api
2.提取原有的watch onRebuild选项为单独的插件,用法与参数与原有一致

ref #10305

@vercel
Copy link

vercel bot commented May 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) May 27, 2023 8:05am

@fz6m
Copy link
Member

fz6m commented May 27, 2023

感谢 PR ,辛苦了 🌹

@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Patch coverage: 12.65% and project coverage change: -0.01 ⚠️

Comparison is base (b62afe8) 29.12% compared to head (a92d4d7) 29.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11203      +/-   ##
==========================================
- Coverage   29.12%   29.12%   -0.01%     
==========================================
  Files         479      480       +1     
  Lines       14435    14478      +43     
  Branches     3399     3405       +6     
==========================================
+ Hits         4204     4216      +12     
- Misses       9501     9529      +28     
- Partials      730      733       +3     
Impacted Files Coverage Δ
...ckages/bundler-esbuild/src/plugins/watchRebuild.ts 0.00% <0.00%> (ø)
...et-umi/src/features/apiRoute/dev-server/esbuild.ts 0.00% <0.00%> (ø)
...ackages/preset-umi/src/features/prepare/prepare.ts 0.00% <0.00%> (ø)
...preset-umi/src/features/ssr/builder/less-loader.ts 77.77% <ø> (+16.37%) ⬆️
...kages/preset-umi/src/utils/routeExportExtractor.ts 0.00% <0.00%> (ø)
...ges/preset-umi/src/features/ssr/builder/builder.ts 27.77% <14.28%> (-0.35%) ⬇️
packages/preset-umi/src/features/prepare/build.ts 61.53% <44.44%> (-5.13%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Chastrlove
Copy link
Contributor Author

感谢 PR ,辛苦了 🌹

我刚在修watch导致第一次拿不到prepare这个问题,你就搞定了,666啊

@sorrycc sorrycc merged commit a278fad into umijs:master May 30, 2023
23 checks passed
@github-actions
Copy link

感谢 PR!如果有兴趣一起参与维护 Umi,可加入我们的 Umi Contributor 群。加入方式是先用钉钉扫下方二维码加我钉钉,记得注明 github id,然后我会拉你到群里。

xiaohuoni pushed a commit that referenced this pull request Jun 13, 2023
* feat: bump esbuild -> 0.17.19 , use the new context api

* fix: 修复watch模式不返回BuildResult与context导致ts报错的bug

* refactor: move esbuild rebuild plugin to esbuild pkg

* chore: code style

* fix: ci

* fix: ensure first build result exist

---------

Co-authored-by: Chenjie Ma <chenjie@udeer.ai>
Co-authored-by: fz6m <59400654+fz6m@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants