Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: icon spin prop warning #11258

Merged
merged 2 commits into from
Jun 12, 2023
Merged

fix: icon spin prop warning #11258

merged 2 commits into from
Jun 12, 2023

Conversation

fz6m
Copy link
Member

@fz6m fz6m commented Jun 8, 2023

fix #11256

修复 Icon 组件的 spin 属性透传下去导致非预期的警告问题

@vercel
Copy link

vercel bot commented Jun 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Jun 8, 2023 3:19pm

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (27937cd) 29.15% compared to head (c7b98d7) 29.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11258   +/-   ##
=======================================
  Coverage   29.15%   29.15%           
=======================================
  Files         483      483           
  Lines       14607    14607           
  Branches     3447     3447           
=======================================
  Hits         4258     4258           
  Misses       9601     9601           
  Partials      748      748           
Impacted Files Coverage Δ
packages/preset-umi/src/features/icons/icons.ts 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sorrycc sorrycc merged commit dfe46cd into umijs:master Jun 12, 2023
23 checks passed
xiaohuoni pushed a commit that referenced this pull request Jun 13, 2023
* fix: icon spin prop warning

* fix: ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

icons的 spin属性问题
2 participants